support amp training for video classification models #5023
Conversation
|
Hi @kbozas! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 4541dfa (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Thanks for the PR @kbozas!
I left couple of comments but nothing major. We will need to verify that the script runs on our internal infra prior merging this.
Edit: Don't worry about the failing unittest_onnx test. It's flaky and we will fix it separately. It's not you who broke it.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I confirmed that |
|
@kbozas LGTM, thanks for the contribution! |
|
Great, thank you! |
Summary: * support amp training for video classification models * Removed extra empty line and used scaler instead of args.amp as function argument * apply formating to pass lint tests Reviewed By: NicolasHug Differential Revision: D32950942 fbshipit-source-id: a50fd25f90d96f13ff8023f84d89951b198af2da Co-authored-by: Konstantinos Bozas <kbz@kbz-mbp.broadband>
Replaces uses of
apex.ampwith PyTorch's amp in Video Classfication.Part of #4509
cc @datumbox