Skip to content

Removing code coverage and cleanup tox #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 2, 2022
Merged

Removing code coverage and cleanup tox #5042

merged 7 commits into from
Feb 2, 2022

Conversation

oke-aditya
Copy link
Contributor

I don't think so these files or stuff are used let's see.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 90a8f70 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NicolasHug
NicolasHug reviewed Dec 7, 2021
View reviewed changes
oke-aditya
oke-aditya commented Dec 7, 2021
View reviewed changes
Copy link
Contributor Author

@oke-aditya oke-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying changes on the fly

@oke-aditya oke-aditya marked this pull request as ready for review December 7, 2021 12:53
@oke-aditya
Copy link
Contributor Author

I think this should be good. cc @NicolasHug @pmeier

@oke-aditya oke-aditya requested a review from NicolasHug December 7, 2021 12:53
@oke-aditya
Copy link
Contributor Author

Additionally we can think about cleaning up pytest.ini, setup.cfg and pyproject.toml to a single file. Probably just keep pyproject.ml. (Not sure if mypy too can be combined)

NicolasHug
NicolasHug reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oke-aditya .

I don't mind removing the --cov part as we don't use it (I think).

@NicolasHug
Copy link
Member

Additionally we can think about cleaning up pytest.ini, setup.cfg and pyproject.toml to a single file. Probably just keep pyproject.ml. (Not sure if mypy too can be combined)

I would rather keep things as is.
Any change we make about these will need to be carefully checked on the fbcode side, which has its own requirements and constraints. We wouldn't gain a tremendous value by merging all these into one file anyway, and the low benefit doesn't outweight the extra-work IMHO.

oke-aditya
oke-aditya commented Dec 7, 2021
View reviewed changes
@oke-aditya
Copy link
Contributor Author

oke-aditya commented Dec 7, 2021 •
edited
Loading

I'm little bit scared 😨 Since last time I had broken the docs while modifying such files.

I hope I don't mess up this time 😅

pmeier
pmeier approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @oke-aditya!

@oke-aditya oke-aditya requested a review from NicolasHug December 7, 2021 19:30
@oke-aditya
Copy link
Contributor Author

CI seems all green. Hopefully this doesn't break stuff on fbcode side.

@oke-aditya
Copy link
Contributor Author

I guess it's not breaking anything. (But take no risks, I can close it otherwise)

cc @datumbox @NicolasHug

datumbox
datumbox approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oke-aditya
Copy link
Contributor Author

Aah finally, Is everything fine on fbcode side? I don't want to break something again 😛

@datumbox
Copy link
Contributor

datumbox commented Feb 2, 2022 •
edited
Loading

@oke-aditya I don't think this runs at all on FBcode. We should be good. Sorry for keeping you waiting. Sometimes there are too many things happening at the same time, so pinging us is a good strat.

@datumbox datumbox merged commit 435eddf into pytorch:main Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@oke-aditya oke-aditya deleted the remove_coverage branch February 2, 2022 15:36
facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2022
@jdsgomes @pmeier
@datumbox @facebook-github-bot
[fbsync] Removing code coverage and cleanup tox (#5042)
bf3cce1 
Summary:
* remove coveragerc

* edit shell scripts

* drop tox

* Apply suggestions from code review

* Update setup.cfg

Reviewed By: NicolasHug

Differential Revision: D34140263

fbshipit-source-id: 761849a67a612a515600c04e9f580c2d9944ba4e

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

+1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oke-aditya @facebook-github-bot @NicolasHug @datumbox @pmeier