Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Dec 8, 2021

Without this patch, the remove_finished flag is not honored unless we are only decompressing a file rather than extracting it.

cc @pmeier

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 8, 2021

💊 CI failures summary and remediations

As of commit 226b621 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pmeier pmeier merged commit 65438e9 into pytorch:main Dec 8, 2021
@pmeier pmeier deleted the remove-finished-archive branch December 8, 2021 13:00
facebook-github-bot pushed a commit that referenced this pull request Dec 9, 2021
Reviewed By: NicolasHug

Differential Revision: D32950930

fbshipit-source-id: eea37637cf3ca5f600f4d247bc4c450ea6a6a9fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_finished is not used if archive_type is not None in extract_archive
3 participants