-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Fix draw_bounding_boxes
for tensors on GPU
#5101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 858d63a (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sumanthratna for the fix. I guess this may have only been tested for CPU tensors only. I see a potential for a similar issue in draw_keypoints(). Do you want to fix that as well?
sure, I can fix that issue—should I do it in a separate PR or add it to this one? |
Feel free to create a separate PR, thanks! |
Hey @prabhat00155! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: prabhat00155 Differential Revision: D33253480 fbshipit-source-id: 298255437e7faa1f86db16ad246c8e536980cd92
Sorry, but I guess the label for this should be bug fix and not other. |
Background
without this PR, this happens when
image
is on a CUDA device:Notes
torch.no_grad