Remove Python 3.6 from CI #5152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 9541dfa (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
prabhat00155
added
module: ci
other
seemethere
approved these changes
Dec 31, 2021
|
I'm happy to see this, thanks for working on it @prabhat00155 . Has pytorch core confirmed that they would drop 3.6 in the next release? We discussed it in pytorch/pytorch#69005 but there was no definitive decision last time I checked. Perhaps @seemethere @malfet could confirm that core is indeed going to drop 3.6? |
|
We intend to drop 3.6 since it has hit EOL |
facebook-github-bot
pushed a commit
to meta-pytorch/data
that referenced
this pull request
Jan 4, 2022
Summary: Python 3.6 reached EOL [last month](https://endoflife.date/python). `torchvision` already dropped support for it in pytorch/vision#5152 and there is pytorch/pytorch#69005 to do the same for PyTorch core. Pull Request resolved: #156 Reviewed By: malfet, VitalyFedyunin Differential Revision: D33404751 Pulled By: ejguan fbshipit-source-id: 8cb8ab50307eeac49c85197fdbb46282f5daa7fa
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
Reviewed By: datumbox, prabhat00155 Differential Revision: D33405357 fbshipit-source-id: 46ed894131bdb17cf13d9e1f7dfecb664b19992c
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
Differential Revision: D33405357 Original commit changeset: 46ed894131bd Original Phabricator Diff: D33405357 fbshipit-source-id: 96e015f4eead557e596c645b72602c2edcf4fce6
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
Reviewed By: sallysyw Differential Revision: D33479263 fbshipit-source-id: df52d6ff27552e4a88586dfed14856d64ee4a841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 reached end of life on 23 Dec 2021(https://endoflife.date/python).
Failing test: https://app.circleci.com/pipelines/github/pytorch/vision/13644/workflows/b9b3b259-1f6c-4cfd-8f3b-f42e9db075d0/jobs/1097625 (due to pyav installation)
cc @seemethere