Skip to content

Conversation

mrinath123
Copy link
Contributor

@mrinath123 mrinath123 commented Jan 5, 2022

Fixes #5163

Updated the example for the fasterrcnn_resnet50_fpn model.
Previously there was an error for the output during training phase because the bboxes were initialized randomly, and not matching the coordinate criteria for fasterrcnn.
With this update, the coordinates of bboxes are fixed.

@facebook-github-bot
Copy link
Contributor

Hi @mrinath123!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 5, 2022

💊 CI failures summary and remediations

As of commit 42d8052 (more details on the Dr. CI page):



1 failure not recognized by patterns:

Job Step Action
CircleCI unittest_macos_cpu_py3.7 Run tests 🔁 rerun

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox
Copy link
Contributor

datumbox commented Jan 5, 2022

@mrinath123 Looks good! Unfortunately, I'm not able to merge until the CLA is signed. Could you look into the #5165 (comment) from the bot?

@mrinath123
Copy link
Contributor Author

@datumbox Hi! I signed the CLA, it said it would take some time for the tagging process.

@mrinath123
Copy link
Contributor Author

I actually didn't know I have to sign it first, sorry for that.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mrinath123
Copy link
Contributor Author

@datumbox can you see it now, the CLA issue is solved.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mrinath123 thanks for your contribution to TorchVision! Looking forward for more on the future.

@datumbox datumbox merged commit 93ec8bf into pytorch:main Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@mrinath123
Copy link
Contributor Author

Thanks @datumbox I will do my best

facebook-github-bot pushed a commit that referenced this pull request Jan 8, 2022
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: sallysyw

Differential Revision: D33479275

fbshipit-source-id: 9a1e341daf235ebbbdb84f4d13bc50405b9c3ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example doesnt work
3 participants