-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Updated the example for fasterrcnn_resnet50 #5165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mrinath123! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 42d8052 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 3 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
@mrinath123 Looks good! Unfortunately, I'm not able to merge until the CLA is signed. Could you look into the #5165 (comment) from the bot? |
@datumbox Hi! I signed the CLA, it said it would take some time for the tagging process. |
I actually didn't know I have to sign it first, sorry for that. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@datumbox can you see it now, the CLA issue is solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @mrinath123 thanks for your contribution to TorchVision! Looking forward for more on the future.
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Thanks @datumbox I will do my best |
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Reviewed By: sallysyw Differential Revision: D33479275 fbshipit-source-id: 9a1e341daf235ebbbdb84f4d13bc50405b9c3ea3
Fixes #5163
Updated the example for the fasterrcnn_resnet50_fpn model.
Previously there was an error for the output during training phase because the bboxes were initialized randomly, and not matching the coordinate criteria for fasterrcnn.
With this update, the coordinates of bboxes are fixed.