Skip to content

Modifying keypoint_rcnn.py for keypoint_predictor issue #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2022
Merged

Modifying keypoint_rcnn.py for keypoint_predictor issue #5180

merged 4 commits into from
Jan 10, 2022

Conversation

themendu
Copy link
Contributor

@themendu themendu commented Jan 9, 2022 •
edited by datumbox
Loading

Fixes #5126

Hi @datumbox, I have created a PR for the issue #5126. This is my first PR. Please review and comment on it. Thank you!

cc @datumbox

@facebook-github-bot
Copy link
Contributor

Hi @themendu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 9, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1890649 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@themendu themendu mentioned this pull request Jan 10, 2022
Closed
datumbox
datumbox reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themendu Thanks for the PR, looks good overall. Just one nitpick, let me know what you think.

@themendu @datumbox
Update torchvision/models/detection/keypoint_rcnn.py
87250e4 
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
themendu
themendu commented Jan 10, 2022
View reviewed changes
Copy link
Contributor Author

@themendu themendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @datumbox for directly including the else statement without complicating the issue.

datumbox
datumbox approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @themendu. Let's wait for green CI and I'll merge.

Thanks for your first contribution, looking forward to more on the future. :)

@datumbox datumbox merged commit cc0d1be into pytorch:main Jan 10, 2022
facebook-github-bot pushed a commit that referenced this pull request Jan 17, 2022
@datumbox @facebook-github-bot
[fbsync] Modifying keypoint_rcnn.py for keypoint_predictor issue (#5180)
d7e9d37 
Summary:
* Modifying keypoint_rcnn.py

* Update torchvision/models/detection/keypoint_rcnn.py

* Remove unnecessary new line

Reviewed By: NicolasHug

Differential Revision: D33618166

fbshipit-source-id: e7e9eedf9e15fadbee9f1c625bce61dece325dec

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug ciflow/default cla signed module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in keypoint_rcnn initializer
3 participants
@themendu @facebook-github-bot @datumbox