-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Adding prototype flag on reference scripts #5248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding prototype flag on reference scripts #5248
Conversation
💊 CI failures summary and remediationsAs of commit 7a83575 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 2 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
weights = PM.get_weight(args.weights) | ||
transform_test = weights.transforms() | ||
else: | ||
transform_test = PT.Kinect400Eval(crop_size=(112, 112), resize_size=(128, 171)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that the arguments in the two classes take the parameters in different order. We are going to remove the old presets anyway and stick with the second one.
Overall LGTM, can you launch 2 jobs to verify it loads prototype models properly? |
@sallysyw I've checked, see below. Please stamp to unblock.
|
@sallysyw Thanks for the careful reviews, checked again everything and looks OK. |
Summary: * Adding prototype flag on reference scripts. * Import prototype instead of models/transforms. * Correcting exception type. * fixing none referencing Reviewed By: jdsgomes, prabhat00155 Differential Revision: D33739376 fbshipit-source-id: 18751cf5174ff27a5d99e120eaa9e47a02d5fec7
Previously we've added in the reference scripts a
--weights
argument which operates as a feature switch for the prototype area (None
vs fully weights name). When this was first introduced, we just wanted to confirm that the new model builders yielded the same results as the old ones for pre-trained models. Thus we only focused on inference.Unfortunately the old approach of checking if
weights
wasNone
won't work if we have models that haven't been graduated from the prototype area and need training. In this PR, we add the explicit feature switch--prototype
which allows us to access the prototype model builders.