Skip to content

Conversation

hmaarrfk
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 23, 2022

💊 CI failures summary and remediations

As of commit 780adc6 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@hmaarrfk
Copy link
Contributor Author

Running:

$ ufmt format setup.py
Formatted setup.py
$ git diff

yeilds mods to things I did not touch

diff --git a/setup.py b/setup.py
index 70ba0aa2e..85f779f13 100644
--- a/setup.py
+++ b/setup.py
@@ -7,9 +7,9 @@ import subprocess
 import sys
 
 import torch
-from pkg_resources import parse_version, get_distribution, DistributionNotFound
-from setuptools import setup, find_packages
-from torch.utils.cpp_extension import BuildExtension, CppExtension, CUDAExtension, CUDA_HOME
+from pkg_resources import DistributionNotFound, get_distribution, parse_version
+from setuptools import find_packages, setup
+from torch.utils.cpp_extension import BuildExtension, CppExtension, CUDA_HOME, CUDAExtension
 
 
 def read(*names, **kwargs):

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hmaarrfk , LGTM. I'll let @datumbox take another look at this one.

Out of curiosity what was the compiler you needed to use?

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks!

@datumbox datumbox merged commit 44ae1e5 into pytorch:main Jan 24, 2022
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@hmaarrfk
Copy link
Contributor Author

Thanks

facebook-github-bot pushed a commit that referenced this pull request Jan 26, 2022
)

Summary:
* Allow gcc to be overwritten with an environment variable

* change quoting style

Reviewed By: jdsgomes, prabhat00155

Differential Revision: D33739388

fbshipit-source-id: 1db881bc1b6dd6d1078f2482f1d1267db4d45f53

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
@hmaarrfk
Copy link
Contributor Author

as for the curiosity quesiton. Conda forge compilers are all prefixed, and this helps for cross compilation too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants