-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Avoid inplace modification of target boxes in detection references #5289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @rvandeghen! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 4c1fb15 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 8 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
@rvandeghen Thanks for the PR. Looks like our CI is fried at the moment... It's not because of your changes. Note that I won't be able to merge this until the CLA is signed, so please have a look at #5289 (comment). Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution @rvandeghen. :)
…rences (#5289) Summary: datumbox Reviewed By: kazhang Differential Revision: D33927504 fbshipit-source-id: 93925ab04ce67560b162132060fbef13a04c159f Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Fixes #5221