Skip to content

Conversation

rvandeghen
Copy link
Contributor

@rvandeghen rvandeghen commented Jan 26, 2022

Fixes #5221

@facebook-github-bot
Copy link
Contributor

Hi @rvandeghen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2022

💊 CI failures summary and remediations

As of commit 4c1fb15 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 8 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox changed the title Solve #5221 Avoid inplace modification of target boxes in detection references Jan 26, 2022
@datumbox
Copy link
Contributor

@rvandeghen Thanks for the PR.

Looks like our CI is fried at the moment... It's not because of your changes.

Note that I won't be able to merge this until the CLA is signed, so please have a look at #5289 (comment). Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @rvandeghen. :)

@datumbox datumbox merged commit e13da8b into pytorch:main Jan 27, 2022
facebook-github-bot pushed a commit that referenced this pull request Feb 3, 2022
…rences (#5289)

Summary:
datumbox

Reviewed By: kazhang

Differential Revision: D33927504

fbshipit-source-id: 93925ab04ce67560b162132060fbef13a04c159f

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behavior in detection reference code
3 participants