fix annotations for Python >= 3.8 #5301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit c1059bc (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This reverts commit b935c83.
pmeier
commented
Jan 28, 2022
| pytorch_dep += "==" + os.getenv("PYTORCH_VERSION") | ||
|
|
||
| requirements = [ | ||
| "typing_extensions", |
There was a problem hiding this comment.
PyTorch core already hard-depends on it: https://github.com/pytorch/pytorch/blob/be2dc8f2940d3c95941516a811be8c504910d1ea/setup.py#L408-L411
pmeier
added
dependency issue
other
datumbox
reviewed
Jan 28, 2022
| padding: Union[int, List[int], Tuple[int, ...]], | ||
| fill: Optional[Union[float, List[float], Tuple[float, ...]]] = 0, | ||
| padding_mode: str = "constant", | ||
| padding_mode: Literal["constant", "edge", "reflect", "symmetric"] = "constant", |
There was a problem hiding this comment.
That's a new one for me, Literally.
NicolasHug
reviewed
Jan 28, 2022
| self.labels: Optional[np.ndarray] | ||
| if self.split == "train": | ||
| self.data, self.labels = self.__loadfile(self.train_list[0][0], self.train_list[1][0]) | ||
| self.labels = cast(np.ndarray, self.labels) |
There was a problem hiding this comment.
We already have self.labels: Optional[np.ndarray] above, should we remove one of these?
There was a problem hiding this comment.
I missed that. Let me have a look.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: * run mypy on Python 3.9 * appease mypy * Revert "run mypy on Python 3.9" This reverts commit b935c83. Reviewed By: kazhang Differential Revision: D33927516 fbshipit-source-id: 07741549abeede756d941bdd105f8df3293e179e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.