Skip to content

Expose generalized_box_iou to docs #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Expose generalized_box_iou to docs #5302

merged 3 commits into from
Feb 2, 2022

Conversation

oke-aditya
Copy link
Contributor

@oke-aditya oke-aditya commented Jan 27, 2022 •
edited
Loading

Btw where are the tests for this loss function and also for sigmoid focal loss?

Also do you think it is worth to have a canonical box_iou_loss function?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 07a5874 (more details on the Dr. CI page):

  • 3/3 failures introduced in this PR

3 failures not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.7_cu111 packaging/build_conda.sh 🔁 rerun
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
CircleCI binary_linux_conda_py3.7_cu115 packaging/build_conda.sh 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit cd00ea1 into pytorch:main Feb 2, 2022
@oke-aditya oke-aditya deleted the giou_fix branch February 2, 2022 12:27
facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2022
@jdsgomes @datumbox @facebook-github-bot
[fbsync] Expose generalized_box_iou to docs (#5302)
f472469 
Summary:
* Improve giou loss

* Fix red

Reviewed By: NicolasHug

Differential Revision: D34140247

fbshipit-source-id: c020387c35ebd0e2314d1ddae95da361c4d91b3f

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oke-aditya @facebook-github-bot @datumbox