Remove custom ops interpolation with antialiasing #5329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 1e8caca (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@vfdev-5 The failures seem related. |
|
Oh, I was thinking that pytorch/pytorch#71937 is already in nightly ... Let's wait then with this PR. |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 7, 2022
Summary: Description: - Added missing antialias argument to functional.pyi.in - mypy is happy if checking `interpolate` method with antialias argument Related torchvision issue: pytorch/vision#5329 Pull Request resolved: #72420 Reviewed By: mruberry Differential Revision: D34043182 Pulled By: albanD fbshipit-source-id: ca64a8f0d2516c1be5b060c1c24e0b1ed2127b96
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 7, 2022
Summary: Description: - Added missing antialias argument to functional.pyi.in - mypy is happy if checking `interpolate` method with antialias argument Related torchvision issue: pytorch/vision#5329 Pull Request resolved: #72420 Reviewed By: mruberry Differential Revision: D34043182 Pulled By: albanD fbshipit-source-id: ca64a8f0d2516c1be5b060c1c24e0b1ed2127b96 (cherry picked from commit 7c8a90c)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Description: - Added missing antialias argument to functional.pyi.in - mypy is happy if checking `interpolate` method with antialias argument Related torchvision issue: pytorch/vision#5329 Pull Request resolved: pytorch/pytorch#72420 Reviewed By: mruberry Differential Revision: D34043182 Pulled By: albanD fbshipit-source-id: ca64a8f0d2516c1be5b060c1c24e0b1ed2127b96 (cherry picked from commit 7c8a90cbfa54b4369644bf69cce1eb162f66b3f7)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 9, 2022
Summary: Description: - Added missing antialias argument to functional.pyi.in - mypy is happy if checking `interpolate` method with antialias argument Related torchvision issue: pytorch/vision#5329 Pull Request resolved: pytorch/pytorch#72420 Reviewed By: mruberry Differential Revision: D34043182 Pulled By: albanD fbshipit-source-id: ca64a8f0d2516c1be5b060c1c24e0b1ed2127b96 (cherry picked from commit 7c8a90cbfa54b4369644bf69cce1eb162f66b3f7)
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Summary: * Removed custom ops for interp with AA * Fixed umft issues Reviewed By: sallysyw Differential Revision: D34265746 fbshipit-source-id: f30177bf2fd625b8b2b923e4db45180779a2e6ad Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PyTorch now suppports interpolation op with antialiasing: https://pytorch.org/docs/master/generated/torch.nn.functional.interpolate.html#torch.nn.functional.interpolate
In this PR I remove prelimiary and temporary private custom ops.