Skip to content

Add warning in docs and Cpp code for nvjpeg leak on CUDA < 11.6 #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Add warning in docs and Cpp code for nvjpeg leak on CUDA < 11.6 #5482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8033e36
Add warning in docs and Cpp code for nvjpeg leak on CUDA < 11.6
NicolasHug Feb 25, 2022
c7152c2
Merge branch 'main' into nvjpeg_leak_warning
NicolasHug Feb 25, 2022
9414ef7
Merge branch 'main' into nvjpeg_leak_warning
NicolasHug Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions torchvision/csrc/io/image/cuda/decode_jpeg_cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,27 @@ torch::Tensor decode_jpeg_cuda(

TORCH_CHECK(device.is_cuda(), "Expected a cuda device")

int major_version;
int minor_version;
nvjpegStatus_t get_major_property_status =
nvjpegGetProperty(MAJOR_VERSION, &major_version);
nvjpegStatus_t get_minor_property_status =
nvjpegGetProperty(MINOR_VERSION, &minor_version);

TORCH_CHECK(
get_major_property_status == NVJPEG_STATUS_SUCCESS,
"nvjpegGetProperty failed: ",
get_major_property_status);
TORCH_CHECK(
get_minor_property_status == NVJPEG_STATUS_SUCCESS,
"nvjpegGetProperty failed: ",
get_minor_property_status);
if ((major_version < 11) || ((major_version == 11) && (minor_version < 6))) {
TORCH_WARN_ONCE(
"There is a memory leak issue in the nvjpeg library for CUDA versions < 11.6. "
"Make sure to rely on CUDA 11.6 or above before using decode_jpeg(..., device='cuda').");
}

at::cuda::CUDAGuard device_guard(device);

// Create global nvJPEG handle
Expand Down
4 changes: 4 additions & 0 deletions torchvision/io/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ def decode_jpeg(
with `nvjpeg <https://developer.nvidia.com/nvjpeg>`_. This is only
supported for CUDA version >= 10.1

.. warning::
There is a memory leak in the nvjpeg library for CUDA versions < 11.6.
Make sure to rely on CUDA 11.6 or above before using ``device="cuda"``.

Returns:
output (Tensor[image_channels, image_height, image_width])
"""
Expand Down