Improve test_videoapi #5497
Merged
Improve test_videoapi #5497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prabhat00155
commented
Feb 28, 2022
prabhat00155
commented
- Use parametrize instead of looping over the list. This would help point out the exact scenario in case of failures.
- Remove unused variables
- Simplify if conditions
💊 CI failures summary and remediationsAs of commit 6d95c98 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Reviewed By: datumbox Differential Revision: D34579508 fbshipit-source-id: 9f9e5acf45772d5a99cdeae51efff4e66ad9284c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.