Skip to content

Improve test_video_reader #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2022
Merged

Improve test_video_reader #5498

merged 3 commits into from
Mar 1, 2022

Conversation

prabhat00155
Copy link
Contributor

  • Use parametrize instead of looping over the list. This would help point out the exact scenario in case of failures.
  • Remove unused variables
  • Capitalise constant

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 28, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6b9c625 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that all changes are about adding parameterize. LGTM, thanks!

@prabhat00155 prabhat00155 merged commit c50d488 into pytorch:main Mar 1, 2022
@prabhat00155 prabhat00155 deleted the prabhat00155/cleanup_test2 branch March 1, 2022 19:49
facebook-github-bot pushed a commit that referenced this pull request Mar 5, 2022
@prabhat00155 @facebook-github-bot
[fbsync] Improve test_video_reader (#5498)
23ac9ae 
Summary:
* Improve test_video_reader

* Fix linter error

Reviewed By: datumbox

Differential Revision: D34579500

fbshipit-source-id: 8f1ef8897c0bd00b9e73a495264db16c0e74746f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: io module: video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhat00155 @facebook-github-bot @datumbox