Fix libtorchvision.so not able to encode images by adding *_FOUND macros to CMakeLists.txt

[zeruniverse]

When building libtorchvision.so for C++ following README

mkdir build
cd build
# Add -DWITH_CUDA=on support for the CUDA if needed
cmake ..
make
make install

I found the built library is not linked to libpng / libjpeg. After some debug, I found #if *_FOUND presents in related source files but corresponding macros is not set in CMakeLists.txt.

I have tested that with this PR, the built libtorchvision.so successfully links to libpng and libjpeg

[facebook-github-bot]

Hi @zeruniverse!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit ab362f7 (more details on the Dr. CI page):

---

• 1/1 failures introduced in this PR

---

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

cmake_windows_gpu (1/1)

Step: "set -ex
source packaging/windows/internal/vc_install_helper.sh
packaging/windows/internal/cuda_install.bat
packaging/build_cmake.sh
" (full log | diagnosis details | 🔁 rerun)

C:\Users\circleci\project\cpp_build\Release\tor...rs\circleci\project\cpp_build\torchvision.vcxproj]

       "C:\Users\circleci\project\cpp_build\INSTALL.vcxproj" (default target) (1) ->
       "C:\Users\circleci\project\cpp_build\ALL_BUILD.vcxproj" (default target) (3) ->
       "C:\Users\circleci\project\cpp_build\torchvision.vcxproj" (default target) (4) ->
       (Link target) -> 
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegGetProperty referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegCreateSimple referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegJpegStateCreate referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegJpegStateDestroy referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegGetImageInfo referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         decode_jpeg_cuda.obj : error LNK2019: unresolved external symbol nvjpegDecode referenced in function "class at::Tensor __cdecl vision::image::decode_jpeg_cuda(class at::Tensor const &,__int64,struct c10::Device)" (?decode_jpeg_cuda@image@vision@@YA?AVTensor@at@@AEBV34@_JUDevice@c10@@@Z) [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
         C:\Users\circleci\project\cpp_build\Release\torchvision.dll : fatal error LNK1120: 6 unresolved externals [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]

    0 Warning(s)
    7 Error(s)

Time Elapsed 00:00:03.51


Exited with code exit status 1

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[NicolasHug]

Thanks @zeruniverse , LGTM