Skip to content

fix typo in docstrings of some transforms #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2022
Merged

fix typo in docstrings of some transforms #5609

merged 2 commits into from
Mar 14, 2022

Conversation

georggrab
Copy link
Contributor

@georggrab georggrab commented Mar 14, 2022 •
edited by datumbox
Loading

Fixes #5606

@facebook-github-bot
Copy link
Contributor

Hi @talkdirty!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 14, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6e71481 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@georggrab georggrab mentioned this pull request Mar 14, 2022
Closed
NicolasHug
NicolasHug approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @talkdirty

@datumbox
Copy link
Contributor

@talkdirty Thanks! FYI the system won't allow us to merge the PR until the CLA is completed. See the bot's #5609 (comment) for how to do it. Don't worry about the failing test on cmake, it's unrelated to your changes.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@datumbox datumbox merged commit d7a908d into pytorch:main Mar 14, 2022
facebook-github-bot pushed a commit that referenced this pull request Mar 15, 2022
@datumbox @facebook-github-bot
[fbsync] fix typo in docstrings of some transforms (#5609)
9ce627a 
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: vmoens

Differential Revision: D34878990

fbshipit-source-id: 4376335a88c247c506d889e87daed6596ffa4122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
bug ciflow/default cla signed module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transforms.{RandomAdjustSharpness,RandomPosterize}: p parameter
4 participants
@georggrab @facebook-github-bot @datumbox @NicolasHug