Skip to content

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Mar 15, 2022

Cherrypicking 3140045 D34878986

Patch for #5502

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 15, 2022

💊 CI failures summary and remediations

As of commit 9aaa3a1 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox changed the title [FBcode->GH] JIT scriptable _max_value D34878986 [FBcode->GH] JIT scriptable _max_value Mar 15, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT,

In a next possible future iteration on that we can try (1 << 63) - 1 instead of 9223372036854775807...

@datumbox datumbox merged commit 00c119c into pytorch:main Mar 15, 2022
@datumbox datumbox deleted the fbcode/max_value branch March 15, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants