Skip to content

Default tracer args #5637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 24, 2022
Merged

Default tracer args #5637

merged 11 commits into from
Mar 24, 2022

Conversation

jdsgomes
Copy link
Contributor

@jdsgomes jdsgomes commented Mar 17, 2022 •
edited
Loading

Always sets default tracer kwargs

adresses #5508

cc @alexander-soare @datumbox

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 17, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 81ad361 (more details on the Dr. CI page):

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_linux_gpu Build torchvision C++ distribution and test 🔁 rerun

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdsgomes, it looks good overall. Just one comment concerning the visibility of the method:

datumbox
datumbox approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jdsgomes jdsgomes merged commit 52ba090 into pytorch:main Mar 24, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@jdsgomes @facebook-github-bot
[fbsync] Default tracer args (#5637)
a888726 
Summary:
* set default tracer kwargs always

* simplify code

* torchvision/models/feature_extraction.py

* Adress PR comments

* fix doc format

* fix formatting

* fix doc error

(Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216792

fbshipit-source-id: 0ecefb1393296abf169909a64eeef5320e82d7c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/default cla signed enhancement topic: feature extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdsgomes @facebook-github-bot @datumbox