call _upcast to consider overflow for computing giou loss #5685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giou loss is weak at overflow problem because it computes area of box. https://github.com/pytorch/vision/blob/main/torchvision/ops/boxes.py#L226-L242
💊 CI failures summary and remediationsAs of commit ad704ed (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
reviewed
Mar 26, 2022
There was a problem hiding this comment.
@developer0hye Thanks for the PR. Looks like something we need to address. I've added a comment below for your attention, let me know your thoughts.
|
@datumbox Thanks! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
…5685) Summary: * call _upcast to consider overflow giou loss is weak at overflow problem because it computes area of box. * cast datatype to float * add ":" to if * lint Test for membership should be 'not in' (E713) (Note: this ignores all push blocking failures!) Reviewed By: datumbox Differential Revision: D35216763 fbshipit-source-id: 804469851d1ad3ac1537c5711f72db10086e9110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
giou loss is weak at overflow problem because it computes area of box.
https://github.com/pytorch/vision/blob/main/torchvision/ops/boxes.py#L226-L242