Skip to content

remove unnecessary pytest install #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2022
Merged

remove unnecessary pytest install #5739

merged 1 commit into from
Apr 5, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 5, 2022

pytest is already installed during the environment setup:

vision/.circleci/unittest/linux/scripts/environment.yml

Line 5 in 095cabb

- pytest

vision/.circleci/unittest/windows/scripts/environment.yml

Line 5 in 095cabb

- pytest

Thus, passing it again does nothing. For example this CI run.

The following NEW packages will be INSTALLED:

cpuonly            pytorch-nightly/noarch::cpuonly-2.0-0
libuv              pkgs/main/linux-64::libuv-1.40.0-h7b6447c_0
pytorch            pytorch-nightly/linux-64::pytorch-1.12.0.dev20220404-py3.7_cpu_0
pytorch-mutex      pytorch-nightly/noarch::pytorch-mutex-1.0-cpu

NicolasHug
NicolasHug approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM if green

@pmeier pmeier merged commit c6c9ab9 into pytorch:main Apr 5, 2022
@pmeier pmeier deleted the pytest-install branch April 5, 2022 10:24
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
@YosuaMichael @facebook-github-bot
[fbsync] remove unnecessary pytest install (#5739)
7bf8748 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095718

fbshipit-source-id: cd2925c5c6e05593eb55b005139d7978997f25a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot