add warning if font is not set #5785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezwon
commented
Apr 7, 2022
pmeier
reviewed
Apr 7, 2022
pmeier
reviewed
Apr 7, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
pmeier
reviewed
Apr 8, 2022
pmeier
reviewed
Apr 8, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
NicolasHug
reviewed
Apr 8, 2022
oke-aditya
reviewed
Apr 13, 2022
pmeier
reviewed
Apr 14, 2022
pmeier
reviewed
Apr 14, 2022
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
pmeier
approved these changes
Apr 19, 2022
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2022
Summary: * add warning if font is not set * added quotes * added changes after review * Apply suggestions from code review * escaped warning string * Apply suggestions from code review * updated warning message in test * refactored code * Apply suggestions from code review Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095644 fbshipit-source-id: efc171d4f4a5567b48b9365dc35e7d4ac45922a5 Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5725