Skip to content

Conversation

YosuaMichael
Copy link
Contributor

Sub-task for #5688

adding test for generalized_box_iou_loss function

@YosuaMichael YosuaMichael requested a review from pmeier April 11, 2022 09:58
@YosuaMichael YosuaMichael marked this pull request as ready for review April 11, 2022 09:58
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. Otherwise LGTM Yosua! Thank you!

@YosuaMichael YosuaMichael merged commit 9cae156 into pytorch:main Apr 13, 2022
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
Summary:
* Add test for giou_loss

* Use standard assert for integer comparison

* Fix ufmt format and add log after assert

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095688

fbshipit-source-id: 2dafe815e8cfa749cb71ed2071826835a4218425

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants