Skip to content

Conversation

NicolasHug
Copy link
Member

This PR documents make html-noplot before make html in our contributing guide for building the docs.

make html-noplot is enough in 99% of cases, and make html can throw a bunch of scary errors (looking at you ffmpeg example 👀 ).

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those dependency errors are scary and not helpful.

I wonder if a better approach is to create a doc building method that skips any doc building where dependencies are missing. We can emit a warning but not fail. Plus still run some of the galleries when possible.

I'm approving this PR as I think it's on the right direction and we can perhaps consider the above proposal separately. Thought Nicolas?

@NicolasHug
Copy link
Member Author

Maybe we could have a way to bypass an example if there is some failure (the ffmpeg one isn't just a dependency problem but sometimes a dynamic loading issue as well). If someone wants to spend time on this, why not, but I think this will become less and less relevant as we add more examples. Eventually the doc building time will be dominated by the examples (if that's not already the case), and the need for skipping all example building will be even stronger than it is right now

@NicolasHug NicolasHug merged commit 7d83be5 into pytorch:main Apr 21, 2022
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
…#5847)

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095703

fbshipit-source-id: 4c5e3305339f4a64d12546e77697b9d83270dddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants