Replace distutils.spawn with shutil.which per PEP632 in setup script #5849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Apr 21, 2022
|
@NicolasHug the failing unit test seems unrelated to me but I might be missing something. |
|
Yes it's safe to ignore as it's been failing for a while. I'll just wait for @datumbox to take a look before merging. Since all jobs have run (and compiled torchvision) successfully I think this is safe to go on my side |
datumbox
approved these changes
Apr 21, 2022
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2022
…p script (#5849) Summary: Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095709 fbshipit-source-id: 9102f19bd9afa7172c1d0e9985acee405b5fa3fc Co-authored-by: Bruno Korbar <bkorbar@quansight.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #5837