Adding revamp docs for vision_transformers and regnet #5856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Thanks @YosuaMichael , this looks great!
There's a minor rendering issue with the RegNet docstrings, and I have a few minor comments, but other than that it will be good to go
15 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Summary: * Add docs for regnet, still need to update the comment docs on models * Fix a little typo on .rst file * Update regnet docstring * Add vision_transformer docs, and fix typo on regnet docs * Update docstring to make sure it does not exceed 120 chars per line * Improve formatting * Change the new line location for vision_transformer docstring Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095647 fbshipit-source-id: 28fb6a6e253f52586e4cd73b2fb65e2c4fec82cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5833
Adding revamp docs for vision_transformer and regnet.
cc @NicolasHug