AlexNet New Documentation. #5886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Thanks @yassineAlouini , LGTM modulo the reference issue that you correctly flagged!
torchvision/models/alexnet.py
Outdated
Comment on lines
96
to
97
| # TODO: Isn't this the correct paper link? | ||
| # https://proceedings.neurips.cc/paper/2012/file/c399862d3b9d6b76c8436e924a68c45b-Paper.pdf |
There was a problem hiding this comment.
Thanks for flagging this! I think you're correct. Let's use https://papers.nips.cc/paper/2012/hash/c399862d3b9d6b76c8436e924a68c45b-Abstract.html (which doesn't download the pdf immediately)
There was a problem hiding this comment.
Alright, will update this and send the fix. 👌
15 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Summary: * [DOC] Add alexnet new documentation. * [FIX] Fix wrong alexnet header. * [FIX] Fix the AlexNet paper link. Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095661 fbshipit-source-id: ac3114c7d7d975e4bd01078b90253107fa9a4bc4 Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR, I add the AlexNet new documentation.
There is one detail: I think the paper link isn't the correct one or maybe I am missing some context?
The one I think is correct is this one: https://proceedings.neurips.cc/paper/2012/file/c399862d3b9d6b76c8436e924a68c45b-Paper.pdf.