Skip to content

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Apr 27, 2022

No description provided.

@NicolasHug NicolasHug changed the title NOMRG Custom class for weights table Make weights tables row size smaller Apr 28, 2022
@NicolasHug NicolasHug marked this pull request as ready for review April 28, 2022 08:58
@pmeier
Copy link
Collaborator

pmeier commented Apr 28, 2022

Rendered docs.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nicolas!

@NicolasHug
Copy link
Member Author

Rendered docs.

Thanks Philip. It also changes the style of the individual weight tables in the model builders' pages:

image

@NicolasHug NicolasHug merged commit 2921174 into pytorch:main Apr 28, 2022
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug
Copy link
Member Author

Thanks a lot @svekars for the CSS suggestions!

facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary:
* Custom class for weights table

* Proper CSS

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095669

fbshipit-source-id: 9d5a136d78124d20f8fe3ba1817987c7ef8f3a42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants