Skip to content

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Apr 28, 2022

Following up on #5897, this PR introduces the following modifications:

  • creates the new rst doc file for FCN
  • adds the reference on the new page
  • updates the docstring accordingly

Any feedback is welcome!

cc @NicolasHug @datumbox

NicolasHug
NicolasHug previously approved these changes Apr 28, 2022
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm !!

@NicolasHug NicolasHug dismissed their stale review April 28, 2022 13:59

missing attributes

Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm !

@NicolasHug NicolasHug merged commit 2942bfa into pytorch:main May 3, 2022
@frgfm frgfm deleted the fcn-doc branch May 3, 2022 12:59
facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary:
* docs: Added FCN to new doc

* docs: Updated docstring

* docs: Fixed docstring

* Update docs/source/models/fcn.rst

* Apply suggestions from code review

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095707

fbshipit-source-id: f8c9baa10936283efe9a1eaa151c6a79f64195a1

Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>
Co-authored-by: FG Fernandez <�26927750+frgfm@users.noreply.github.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Aditya Oke <47158509+oke-aditya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants