Skip to content

CleanUp DenseNet code #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2022
Merged

CleanUp DenseNet code #5966

merged 2 commits into from
May 9, 2022

Conversation

NicolasHug
Copy link
Member

This PR removes unnecessary calls to add_module() and removes confusing type annotations.

datumbox
datumbox approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and the changes LGTM.

@NicolasHug NicolasHug marked this pull request as ready for review May 9, 2022 09:23
@NicolasHug NicolasHug merged commit ce778bb into pytorch:main May 9, 2022
facebook-github-bot pushed a commit that referenced this pull request May 11, 2022
@datumbox @facebook-github-bot
[fbsync] CleanUp DenseNet code (#5966)
a74cf9b 
Reviewed By: YosuaMichael

Differential Revision: D36281606

fbshipit-source-id: 7a75f10f19bb64a309f25701c9ee363becaee16a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed code quality module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @datumbox @facebook-github-bot