Allow custom docs for Weight enums and Weights fields #5988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 11, 2022
datumbox
approved these changes
May 11, 2022
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2022
Summary: * POC * Update torchvision/models/resnet.py * Apply suggestions from code review * Fix tests * ufmt * Remove useless docstring Reviewed By: datumbox Differential Revision: D36413350 fbshipit-source-id: c7f648a9877195b7fd580ec8a25b281fb8eea9fa Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to document a weight enum, or a single
Weightsclass.rendered docs: https://output.circle-artifacts.com/output/job/cc788413-d4e6-4e1b-be75-453a8b5fb736/artifacts/0/docs/models/generated/torchvision.models.resnet50.html#torchvision.models.ResNet50_Weights