-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Remove comment which is rendered as css class #5995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To verify you can visit While do the same on the current build you can do the same through Circle CI artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks @oke-aditya
I had noticed this, but since it doesn't have any effect I kept it. I still think the comment is useful to provide context to the reader. Without it, we will definitely forget what this file does eventually. If we remove it, the docs will look terrible and we might not notive before it's too late. @oke-aditya can you please try to see if we can add this comment on the line above? If not, I'd prefer referting this PR. |
It's bit bad both the ways. Keeping it means we are injecting CSS which unnecassary (slowing the website) + say torch theme creates a CSS class that uses this. It would mean we are broken as we will override that CSS. I know the comment is crucial but having comment that injects code un intentionally is equally bad. |
I'd really like to get this comment back one way or another. Do you mind trying adding it back in the file? |
Lemme try adding it above so that it will not go inside CSS. Not sure if it would work |
If it doesn't work, we can put back the comment as
This will never correspond to any css class and we'll be safe. Not amazing, but better than not comment at all. |
I think it's possible to fix the HTML and keep the comment. See below:
From here. |
Reviewed By: datumbox Differential Revision: D36413366 fbshipit-source-id: 710068134dbf119675a3d50032b79bb59bb99f76
The comment has unintentional side effect of appearing in css class over generated tables in html pages. Although it doesn't break anything, it could hurt sometime later.
cc @NicolasHug