Add preprocessing information on the Weights documentation #6009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
May 13, 2022
There was a problem hiding this comment.
Thanks @datumbox , I think it looks nice!
Maybe as a follow-up (very low pri) we could check if all the descriptions are the same for a given weight enum. And if they're all the same, then we would just need to document it once at the top, like
all weights below follow the following pre-processing: ...
Just a thought, definitely not worth bothering with that now.
6 tasks
6 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
May 24, 2022
…6009) Summary: * Adding `__repr__` in presets * Adds `describe()` methods to all presets. * Adding transform descriptions in the documentation. * Change "preprocessing" to "inference" Reviewed By: datumbox Differential Revision: D36413356 fbshipit-source-id: f8a88b5e1cab5beca1008d4c5fb88b98102dc389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #6014
Each weight comes with a human-readable description of how the preprocessing happens during inference:
