Models doc revamp: final cleanup #6049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
May 19, 2022
There was a problem hiding this comment.
LGTM, thanks @NicolasHug! Let's merge this "final" PR before the next "final v2". ;)
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: * Remove models.rst * Remove '- New' * Put back torchhub section where it originally was Reviewed By: NicolasHug Differential Revision: D36760929 fbshipit-source-id: f31049101a6bdab43bef8a403c3fff5954226d8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
("Final" until "Final for real" and "Final for real V2" comes along, obviously).
This PR:
models.rstwithmodels_new.rst(diff looks huge but it's really just that (+ 1 ref fix))-into_in metrics.