Skip to content

Conversation

datumbox
Copy link
Contributor

Running the current reference script on cpu throws:

AttributeError: Can't pickle local object 'main.<locals>.copypaste_collate_fn'

This is because the method is nested within another. Moving it on the top-level fixes the issue.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datumbox datumbox merged commit 28557e0 into pytorch:main Jun 21, 2022
@datumbox datumbox deleted the bugfix/copypaste_collate branch June 21, 2022 10:11
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
Reviewed By: datumbox

Differential Revision: D37375005

fbshipit-source-id: 27e405e1f6ee380e9c2036b4b8ceb4ac41324e21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants