Fill arg supports float values, scripted pad op #6226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
LGTM, thanks @vfdev-5. As far as I see, the relevant tests pass and those that fail are for the unrelated reason. I had a look also on the usages of F.pad() in Transforms and it seems that everywhere in the documentation we imply that floats are supported so this aligns with how it's advertised.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Reviewed By: jdsgomes Differential Revision: D37643908 fbshipit-source-id: e6dda3800a505ea8c5edb48d53c873e3f174cb36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.