Skip to content

Conversation

datumbox
Copy link
Contributor

Fixes #6395

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !
I added a comment to discuss

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@datumbox datumbox merged commit bd5f1e3 into pytorch:main Aug 11, 2022
@datumbox datumbox deleted the bugfix/jit_typing branch August 11, 2022 12:10
facebook-github-bot pushed a commit that referenced this pull request Aug 24, 2022
Summary:
* Fix typing jit issue on RoIPool and RoIAlign

* Fix nit.

* Address code review comments.

Reviewed By: datumbox

Differential Revision: D38824239

fbshipit-source-id: b99f12d980e37b29acdbfd26e6995a150a39b9df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between RoIPool's forward and roi_pool
3 participants