Free avPacket on EAGAIN decoder error #6432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: According to the documentation the packet has to be freed after `av_read_frame()` call. ``` If pkt->buf is NULL, then the packet is valid until the next av_read_frame() or until avformat_close_input(). Otherwise the packet is valid indefinitely. In both cases the packet must be freed with av_packet_unref when it is no longer needed. ``` Differential Revision: D38747612 fbshipit-source-id: 28c2d195ee1be63531567a5a4e05f18ad7f6970f
|
This pull request was exported from Phabricator. Differential Revision: D38747612 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
Summary: Pull Request resolved: #6432 According to the documentation the packet has to be freed after `av_read_frame()` call. ``` If pkt->buf is NULL, then the packet is valid until the next av_read_frame() or until avformat_close_input(). Otherwise the packet is valid indefinitely. In both cases the packet must be freed with av_packet_unref when it is no longer needed. ``` Differential Revision: D38747612 fbshipit-source-id: 2e4ccc8365d0d97e5da756ff9c1dcdf27ed323f0
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: pytorch#6432 According to the documentation the packet has to be freed after `av_read_frame()` call. ``` If pkt->buf is NULL, then the packet is valid until the next av_read_frame() or until avformat_close_input(). Otherwise the packet is valid indefinitely. In both cases the packet must be freed with av_packet_unref when it is no longer needed. ``` Differential Revision: D38747612 fbshipit-source-id: 2e4ccc8365d0d97e5da756ff9c1dcdf27ed323f0
|
@NicolasHug That's that it is indeed. I spoke earlier with Joao and this came from the internal diff. Closing as you suggested. |
NicolasHug
added a commit
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: #6432 According to the documentation the packet has to be freed after `av_read_frame()` call. ``` If pkt->buf is NULL, then the packet is valid until the next av_read_frame() or until avformat_close_input(). Otherwise the packet is valid indefinitely. In both cases the packet must be freed with av_packet_unref when it is no longer needed. ``` Differential Revision: D38747612 fbshipit-source-id: 2e4ccc8365d0d97e5da756ff9c1dcdf27ed323f0 Co-authored-by: Oleksandr Voietsa <ovoietsa@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
According to the documentation the packet has to be freed after
av_read_frame()call.Differential Revision: D38747612