Skip to content

Improve the Video Reference scripts #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

Improve the Video Reference scripts #6444

merged 2 commits into from
Aug 18, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Aug 18, 2022 •
edited
Loading

Supports the work on #6412

  • Remove hardcoded resize/crop values and add extra arguments like we do for the classification reference
  • Make --lr estimation similar to every other reference script (avoid multiplying by world-size)
  • Update and centralize the docs. Make sure they are up-to-date.

@datumbox datumbox changed the title Improve the Video References Improve the Video Reference scripts Aug 18, 2022
jdsgomes
jdsgomes approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datumbox datumbox merged commit 97bb6cb into pytorch:main Aug 18, 2022
@datumbox datumbox deleted the references/video branch August 18, 2022 11:19
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2022
@NicolasHug @facebook-github-bot
[fbsync] Introduce resize params, fix lr estimation, update docs. (#6444
cc92d6b 
)

Reviewed By: datumbox

Differential Revision: D39013673

fbshipit-source-id: b2f48dc16310311a2555fde77fae5db8edba8ec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jdsgomes jdsgomes jdsgomes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed enhancement module: documentation module: reference scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @jdsgomes @facebook-github-bot