Skip to content

Fix swapped width and height in DefaultBoxGenerator #6551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix swapped width and height in DefaultBoxGenerator #6551

merged 2 commits into from
Sep 9, 2022

Conversation

nlgranger
Copy link
Contributor

@nlgranger nlgranger commented Sep 9, 2022 •
edited by datumbox
Loading

Fix #6550

Changes image size convention of DefaultBoxGenerator to (h, w). I don't think this is used by models other than SSD which assumes this convention.

@nlgranger
Fix pytorch#6550
8ca0f24 
Changes image size convention to (h, w). I don't think this is used by
models other than SSD which assumes this convention.
@datumbox datumbox changed the title Fix #6550 Fix swapped width and height in DefaultBoxGenerator Sep 9, 2022
datumbox
datumbox approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM.

You are right this went unnoticed because SSD usually operates on H=W.

@datumbox datumbox merged commit f36f351 into pytorch:main Sep 9, 2022
facebook-github-bot pushed a commit that referenced this pull request Sep 12, 2022
@datumbox @nlgranger @facebook-github-bot
[fbsync] Fix #6550 (#6551)
14d8c34 
Summary:
Changes image size convention to (h, w). I don't think this is used by
models other than SSD which assumes this convention.

Reviewed By: YosuaMichael

Differential Revision: D39426990

fbshipit-source-id: 1426e49264b35ef444b6f8208f09df98a4a15e92

Co-authored-by: Nicolas Granger <nicolas.granger@cea.fr>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug cla signed module: models

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swapped width and height in DefaultBoxGenerator

3 participants

@nlgranger @datumbox @facebook-github-bot