Skip to content

[proto] Added consistency tests for detection transforms #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 15, 2022
Merged

[proto] Added consistency tests for detection transforms #6566

merged 8 commits into from
Sep 15, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 12, 2022

No description provided.

@datumbox datumbox requested a review from pmeier September 14, 2022 14:53
pmeier
pmeier reviewed Sep 15, 2022
View reviewed changes
@vfdev-5 vfdev-5 requested a review from pmeier September 15, 2022 09:33
pmeier
pmeier approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, thank you! A few comments inline. Feel free to merge when resolved and CI is green.

@pmeier pmeier merged commit 544a407 into pytorch:main Sep 15, 2022
@vfdev-5 vfdev-5 deleted the proto-tests-refdet-transforms branch September 15, 2022 12:03
@pmeier pmeier mentioned this pull request Sep 15, 2022
Merged
facebook-github-bot pushed a commit that referenced this pull request Sep 15, 2022
@YosuaMichael @pmeier @facebook-github-bot
[fbsync] [proto] Added consistency tests for detection transforms (#6566
18190f7 
)

Summary:
* [proto] Added consistency tests for detection transforms

* Updated tests according to the review

* More updates

Reviewed By: jdsgomes

Differential Revision: D39543272

fbshipit-source-id: 00ab89507161746680b22b95c8d8440753394f08

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmeier pmeier pmeier approved these changes

Assignees

No one assigned

Labels

cla signed module: tests module: transforms prototype topic: object detection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vfdev-5 @pmeier @facebook-github-bot