Skip to content

Fix the error message of _ovewrite_value_param #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2022
Merged

Fix the error message of _ovewrite_value_param #6585

merged 2 commits into from
Sep 15, 2022

Conversation

datumbox
Copy link
Contributor

Originally reported by @pmeier:

The _ovewrite_value_param() method returns the wrong message.

from torchvision.models.segmentation import fcn_resnet101, FCN_ResNet101_Weights

fcn_resnet101(weights=FCN_ResNet101_Weights.DEFAULT, aux_loss=False)
ValueError: The parameter 'False' expected value True but got False instead.

Instead we should have returned the error:

ValueError: The parameter 'aux_loss' expected value True but got False instead.

This PR fixes this.

@datumbox datumbox requested a review from pmeier September 14, 2022 22:02
pmeier
pmeier approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vasilis!

@datumbox datumbox merged commit 57ae04b into pytorch:main Sep 15, 2022
@datumbox datumbox deleted the fix_error_message branch September 15, 2022 08:03
facebook-github-bot pushed a commit that referenced this pull request Sep 15, 2022
@YosuaMichael @facebook-github-bot
[fbsync] Fix the error message of _ovewrite_value_param (#6585)
bbd41ca 
Reviewed By: jdsgomes

Differential Revision: D39543277

fbshipit-source-id: 256aa0cdafeadcfbdce48766768c8c3c0c253c32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
bug cla signed module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @pmeier @facebook-github-bot