Skip to content

Conversation

YosuaMichael
Copy link
Contributor

During FBSync I notice that the PR #6583 break torchmultimodal's test.

Here is the part that break:

with pytest.raises(AssertionError, match="Wrong image height!"):

I modify the diffs internally and this PR is to make sure fbcode and github are in sync.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@YosuaMichael YosuaMichael merged commit 753bf18 into pytorch:main Sep 16, 2022
@github-actions
Copy link

Hey @YosuaMichael!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox added other if you have no clue or if you will manually handle the PR in the release notes and removed bug labels Sep 16, 2022
@datumbox
Copy link
Contributor

@YosuaMichael I changed the classification tag for this. I don't think it's should be called out as a bug on the release notes. Let me know if you think otherwise or feel free to change the tags back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed fb-exported module: models other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants