Skip to content

Update the expected removal date for several deprecated API for release v0.14 #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 29, 2022
Merged

Update the expected removal date for several deprecated API for release v0.14 #6654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b7a757
Update the expected removal date for several deprecated API
YosuaMichael Sep 27, 2022
04a1ff8
Revert the change in models/_utils.py
YosuaMichael Sep 28, 2022
c00901a
Merge branch 'main' into releasev014/change-deprecation
YosuaMichael Sep 29, 2022
4fc6f6a
Remove removal date on pretrained=True
YosuaMichael Sep 29, 2022
4d3a5dc
Update another message related to pretrained=True
YosuaMichael Sep 29, 2022
bc012c6
Also update the warning in kwonly_to_pos_or_kw decorator
YosuaMichael Sep 29, 2022
ba5e0c0
Merge branch 'main' into releasev014/change-deprecation
YosuaMichael Sep 29, 2022
dc3ad75
Update remaining message in _utils.py
YosuaMichael Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions torchvision/models/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def wrapper(*args: Any, **kwargs: Any) -> D:
keyword_only_kwargs = dict(zip(keyword_only_params, keyword_only_args))
warnings.warn(
f"Using {sequence_to_str(tuple(keyword_only_kwargs.keys()), separate_last='and ')} as positional "
f"parameter(s) is deprecated since 0.13 and will be removed in 0.15. Please use keyword parameter(s) "
f"parameter(s) is deprecated since 0.13 and may be removed in the future. Please use keyword parameter(s) "
f"instead."
)
kwargs.update(keyword_only_kwargs)
Expand Down Expand Up @@ -206,13 +206,13 @@ def inner_wrapper(*args: Any, **kwargs: Any) -> M:

if not pretrained_positional:
warnings.warn(
f"The parameter '{pretrained_param}' is deprecated since 0.13 and will be removed in 0.15, "
f"The parameter '{pretrained_param}' is deprecated since 0.13 and may be removed in the future, "
f"please use '{weights_param}' instead."
)

msg = (
f"Arguments other than a weight enum or `None` for '{weights_param}' are deprecated since 0.13 and "
f"will be removed in 0.15. "
f"may be removed in the future. "
f"The current behavior is equivalent to passing `{weights_param}={default_weights_arg}`."
)
if pretrained_arg:
Expand Down Expand Up @@ -250,7 +250,7 @@ def _ovewrite_value_param(param: str, actual: Optional[V], expected: V) -> V:
class _ModelURLs(dict):
def __getitem__(self, item):
warnings.warn(
"Accessing the model URLs via the internal dictionary of the module is deprecated since 0.13 and will "
"be removed in 0.15. Please access them via the appropriate Weights Enum instead."
"Accessing the model URLs via the internal dictionary of the module is deprecated since 0.13 and may "
"be removed in the future. Please access them via the appropriate Weights Enum instead."
)
return super().__getitem__(item)
2 changes: 1 addition & 1 deletion torchvision/transforms/_functional_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@


warnings.warn(
"The 'torchvision.transforms._functional_video' module is deprecated since 0.12 and will be removed in 0.14. "
"The 'torchvision.transforms._functional_video' module is deprecated since 0.12 and will be removed in the future. "
"Please use the 'torchvision.transforms.functional' module instead."
)

Expand Down
2 changes: 1 addition & 1 deletion torchvision/transforms/_transforms_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@


warnings.warn(
"The 'torchvision.transforms._transforms_video' module is deprecated since 0.12 and will be removed in 0.14. "
"The 'torchvision.transforms._transforms_video' module is deprecated since 0.12 and will be removed in the future. "
"Please use the 'torchvision.transforms' module instead."
)

Expand Down