Skip to content

Replace torch.utils.data.graph.traverse with traverse_dps #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2022
+3 −9
Merged

Replace torch.utils.data.graph.traverse with traverse_dps #6657

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6b891c
Replace torch.utils.data.graph.traverse with traverse_dps
NivekT Sep 27, 2022
75a276e
Update on "Replace `torch.utils.data.graph.traverse` with `traverse_d…
NivekT Sep 27, 2022
e882d08
Merge branch 'main' into gh/NivekT/1/head
pmeier Sep 28, 2022
8f3fd4c
Merge branch 'main' into gh/NivekT/1/head
pmeier Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions test/test_prototype_datasets_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from builtin_dataset_mocks import DATASET_MOCKS, parametrize_dataset_mocks
from torch.testing._comparison import assert_equal, ObjectPair, TensorLikePair
from torch.utils.data import DataLoader
from torch.utils.data.graph import traverse
from torch.utils.data.graph import traverse_dps
from torch.utils.data.graph_settings import get_all_graph_pipes
from torchdata.datapipes.iter import ShardingFilter, Shuffler
from torchvision._utils import sequence_to_str
Expand All @@ -22,7 +22,7 @@


def extract_datapipes(dp):
return get_all_graph_pipes(traverse(dp))
return get_all_graph_pipes(traverse_dps(dp))


@pytest.fixture(autouse=True)
Expand All @@ -42,12 +42,6 @@ def test_coverage():
)


# FIXME: This decorator only applies to `test_data_loader`, but we can't put it there because the class-wide fail on
# warnings would take higher priority.
# Although we are not using `traverse(..., only_datapipe=...)` in `test_data_loader` directly, the `DataLoader` does.
# This will emit the warning, which in turn will fail the test if we don't ignore it. There is a push to fix this in
# https://github.com/pytorch/pytorch/pull/85667.
@pytest.mark.filterwarnings("ignore:`only_datapipe` is deprecated:FutureWarning")
@pytest.mark.filterwarnings("error")
class TestCommon:
@pytest.mark.parametrize("name", datasets.list_datasets())
Expand Down Expand Up @@ -111,7 +105,7 @@ def test_transformable(self, dataset_mock, config):
def test_traversable(self, dataset_mock, config):
dataset, _ = dataset_mock.load(config)

traverse(dataset)
traverse_dps(dataset)

@parametrize_dataset_mocks(DATASET_MOCKS)
def test_serializable(self, dataset_mock, config):
Expand Down