Skip to content

Cleanup live docs for v0.13.1 #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Cleanup live docs for v0.13.1 #6709

merged 2 commits into from
Oct 6, 2022

Conversation

YosuaMichael
Copy link
Contributor

@YosuaMichael YosuaMichael commented Oct 5, 2022 •
edited
Loading

Trying to resolve: #6689

We update the docs by using python script in this gist: https://gist.github.com/YosuaMichael/7dd3f610c0584974fd4978e7fb55fd51

With command:

python cleanup_docs_version.py --dir="<path-to-torchvision-repo>/0.13" --clean-version="0.13" --commit-version="0.13.1a0+bddbd7e"

@YosuaMichael YosuaMichael self-assigned this Oct 5, 2022
@YosuaMichael
Copy link
Contributor Author

@NicolasHug comparing with the PR #6211 , in this PR I only update *.html files, and not updating objects.inv file.

Also could you help me to check for versions.html whether the changes there is correct?

NicolasHug
NicolasHug reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yosua,

I think we should just leave 0.13 instead of 0.13.1, as no new features are included in bugfix releases.

@YosuaMichael
Copy link
Contributor Author

Thanks for the suggestion @NicolasHug , I have changed to 0.13 now

pmeier
pmeier approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yosua!

@pmeier pmeier linked an issue Oct 6, 2022 that may be closed by this pull request
Documentation of 0.13.1 is shown as development version #6689
Closed
@YosuaMichael YosuaMichael merged commit 1f9b5c4 into pytorch:gh-pages Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug left review comments

@pmeier pmeier pmeier approved these changes

Assignees

@YosuaMichael YosuaMichael

Labels

cla signed module: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation of 0.13.1 is shown as development version

4 participants

@YosuaMichael @NicolasHug @pmeier @facebook-github-bot