Skip to content

add docstring for dataset wrapper #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 27, 2023
Merged

add docstring for dataset wrapper #7333

merged 11 commits into from
Feb 27, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 24, 2023 •
edited by pytorch-bot bot
Loading

@NicolasHug NicolasHug marked this pull request as ready for review February 24, 2023 16:43
NicolasHug
NicolasHug approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, I pushed some minor changes but I'll approve to unblock. We just need to add more docs to the "special cases" before merging

@NicolasHug NicolasHug mentioned this pull request Feb 24, 2023
Closed
@pmeier
Copy link
Collaborator Author

pmeier commented Feb 27, 2023

Thanks Nicolas! I've added the missing descriptions for the special datasets.

@NicolasHug NicolasHug merged commit 8ee4d59 into pytorch:main Feb 27, 2023
@pmeier pmeier deleted the doc-wrapper branch February 27, 2023 12:29
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

NicolasHug added a commit to NicolasHug/vision that referenced this pull request Feb 27, 2023
@pmeier @NicolasHug
add docstring for dataset wrapper (pytorch#7333)
9bb7e18 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
NicolasHug added a commit that referenced this pull request Feb 27, 2023
@NicolasHug @pmeier
[Cherry-pick for 0.15] add docstring for dataset wrapper (#7333) (#7344)
47c35b8 
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
@NicolasHug @facebook-github-bot
[fbsync] add docstring for dataset wrapper (#7333)
4c362c1 
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D44416633

fbshipit-source-id: e946f32abacd39063618e33bc6b945086ae7edb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: datasets module: documentation module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot