Remove float16 test from skip test since they should get auto skipped #2475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
changed the title
davidel
requested changes
Sep 1, 2020
test/pytorch_test_base.py
Outdated
| 'test_maximum_minimum_type_promotion_xla_float16*', # doesn't raise | ||
| 'test_maximum_minimum_type_promotion_xla_*_bfloat16', # doesn't raise | ||
| 'test_maximum_minimum_type_promotion_xla_*_float16', # doesn't raise | ||
| 'test_maximum_minimum_type_promotion_xla_*bfloat16*', # doesn't raise |
There was a problem hiding this comment.
Hmm, this is not a valid regex. Should use .* instead of * ...
There was a problem hiding this comment.
yup.. you right, I confuse the wildcard with the regex 🤣
JackCaoG
force-pushed
the
remove_float16_skip
branch
from
3b1eacb to
48e5c90
Compare
davidel
approved these changes
Sep 1, 2020
ultrons
pushed a commit
to ultrons/xla
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to explicitly disable the float16 test after #2450 merged.