Skip to content

Remove multithreading as we strongly encourage xmp #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Remove multithreading as we strongly encourage xmp #2811

merged 1 commit into from
Mar 4, 2021

Conversation

jysohn23
Copy link
Collaborator

@jysohn23 jysohn23 commented Mar 4, 2021

No description provided.

@jysohn23 jysohn23 mentioned this pull request Mar 4, 2021
Closed
JackCaoG
JackCaoG reviewed Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update .circleci/test.sh as well(it is commented out right now)?

taylanbil
taylanbil reviewed Mar 4, 2021
View reviewed changes
@jysohn23
Copy link
Collaborator Author

jysohn23 commented Mar 4, 2021

Thanks! Could you update .circleci/test.sh as well(it is commented out right now)?

Done.

JackCaoG
JackCaoG approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jysohn23 !

@jysohn23 jysohn23 merged commit ea15839 into pytorch:master Mar 4, 2021
@jysohn23 jysohn23 deleted the delete-mt-tests branch March 4, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylanbil taylanbil taylanbil approved these changes

@zcain117 zcain117 zcain117 approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jysohn23 @taylanbil @zcain117 @JackCaoG